Add auto teardown of event listeners in child page #1544
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds automatic teardown of event listeners in the child page and standardizes console styling for observer attach/detach logs.
- Introduces a child-scoped listeners helper that tracks teardown callbacks.
- Switches child code to use the new listener helpers and tweaks READY_STATE_CHANGE handling.
- Updates observer logs to use styled console output with HIGHLIGHT/FOREGROUND.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/child/listeners.js | New listener helpers that auto-register teardown callbacks and log add/remove operations |
| packages/child/index.js | Uses new listener helpers, updates READY_STATE_CHANGE logic, adds setup console event, adjusts setup order and removes some inline logging |
| packages/child/observers/visibility.js | Adds styled logging via HIGHLIGHT/FOREGROUND |
| packages/child/observers/resize.js | Adds styled logging via HIGHLIGHT/FOREGROUND |
| packages/child/observers/perf.js | Adds styled logging via HIGHLIGHT/FOREGROUND |
| packages/child/observers/overflow.js | Adds styled logging for detach via HIGHLIGHT |
| packages/child/observers/mutation.js | Switches to styled logging, but missing required imports for style tokens |
| packages/child/observers/utils.js | Adjusts log message to add styling, but missing required imports for style tokens |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
davidjbradshaw
force-pushed
the
detach_listeners
branch
from
721db60 to
2363612
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1 participant
No description provided.